filiph / linkcheck

Fast link checker
https://pub.dartlang.org/packages/linkcheck
MIT License
425 stars 51 forks source link

Fix destination's final URI being saved too early #110

Closed parlough closed 1 year ago

parlough commented 1 year ago

Caching the result worked previously since _finalUri was not passed between isolates with the from-to-map based structure, but causes issues when a page has redirects now since everything is passed. finalUri is used in only a few specific locations, so not caching the result won't be a big deal.

As a better solution and long term improvement, Destination should likely be immutable and not be updated with the results. I'll hopefully be able to work on that soon.

filiph commented 1 year ago

Great! Thank you!