search

filiph / linkcheck

Fast link checker
https://pub.dartlang.org/packages/linkcheck
MIT License
397 stars 51 forks source link

Enable and fix multiple lints for consistency #112

Closed parlough closed 1 year ago

parlough commented 1 year ago

Developed over a few years where common practices have changed and by a few contributors, the style of the code is a bit inconsistent. As I work on more changes, I wanted to have a well-defined style to follow to allow reviewing to be easier and future code to be more consistent.

This PR adds a few lints and fixes them, mostly automatically, but with a few hand made changes as well.

If you prefer other options, like specifying types or using var, let me know. I'm happy to make changes :)

filiph commented 1 year ago

Sweet! The PR is still marked as WIP, so I'll wait. I also assume there are no true semantic changes so I don't plan to review line-by-line. If there are some changes I should have a look at, please direct me to those files.

parlough commented 1 year ago

No semantic changes, just a few minor name changes :)