search

filiph / linkcheck

Fast link checker
https://pub.dartlang.org/packages/linkcheck
MIT License
397 stars 51 forks source link

Use ++ over += 1 #76

Closed kevmoo closed 3 years ago

filiph commented 3 years ago

Thanks Kevin, but is there a strong reason for this change? I have this notion ingrained in me, possibly way back from C++ days, that one should prefer explicit += 1 over the increment operator. It's only 2 more characters, it's clear what it does (assignment), and there's no way you are tempted to put it into some other arithmetic operation and get in some trickiness.

I realize it might be an outdated idea. ¯\_(ツ)_/¯

kevmoo commented 3 years ago

Not a big deal for me at all. I just thought it was funny

On Sun, May 23, 2021, 11:49 Filip Hracek @.***> wrote:

Thanks Kevin, but is there a strong reason for this change? I have this notion ingrained in me, possibly way back from C++ days, that one should prefer explicit += 1 over the increment operator. It's only 2 more characters, it's clear what it does (assignment), and there's no way you are tempted to put it into some other arithmetic operation and get in some trickiness.

I realize it might be an outdated idea. ¯_(ツ)_/¯

— You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub https://github.com/filiph/linkcheck/pull/76#issuecomment-846607661, or unsubscribe https://github.com/notifications/unsubscribe-auth/AAAEFCS53TB3STCPFOBVSODTPFE45ANCNFSM45J4EUMQ .