filipows / angular-animations

:sparkles: Easy, Reusable Animation Utility library for Angular
https://filipows.github.io/angular-animations
MIT License
634 stars 89 forks source link

Encourage the library authors to publish an Ivy distribution. #107

Open Odonno opened 2 years ago

Odonno commented 2 years ago

Like it is said, will you consider moving to Ivy?

mhamri commented 2 years ago

actually it's the ng CLI prompt image

huajian123 commented 2 years ago

Note that Angular 15 will not support non-Ivy view engines and as such this package in it's current state will not work.

filipows commented 2 years ago

Thanks, @huajian123. I'll look into updating the package. I think it should be relatively straightforward to make it compatible with Ivy.

huajian123 commented 2 years ago

thanks

huajian123 commented 1 year ago

Do you have an upgrade plan?

filipows commented 1 year ago

Hey @huajian123, I should be able to update it during Christmas break

filipows commented 1 year ago

I'm looking into it now, just wanted to clarify one thing regarding:

Note that Angular 15 will not support non-Ivy view engines and as such this package in it's current state will not work.

the library will still work with the Ivy renderer thanks to the angular ngcc (Angular Compatibility Compiler) that upgrades non-ivy libraries into ivy-compliant format (during the build time).

huajian123 commented 1 year ago

ok thank you

byjokese commented 1 year ago

I'm looking into it now, just wanted to clarify one thing regarding:

Note that Angular 15 will not support non-Ivy view engines and as such this package in it's current state will not work.

the library will still work with the Ivy renderer thanks to the angular ngcc (Angular Compatibility Compiler) that upgrades non-ivy libraries into ivy-compliant format (during the build time).

That means that we are not going to see the update, because we will let it ngcc do it for us, or there are still plans to update this?

Is this repo on manteinance only or are any updates planed for the future, just asking out of quriosity. Im OK with it as it is. ;)

Flusinerd commented 1 year ago

NGCC will be removed with Angular 16. Therefore a update will be mandatory to keep using this. https://github.com/angular/angular/commit/48aa96ea13ebfadf2f6b13516c7702dae740a7be

charsleysa commented 1 year ago

@filipows I've created a PR to upgrade to Angular 15 #134

filipows commented 1 year ago

Thank you @charsleysa for your work :heart:

I have published the new version under the 0.15.0-beta.0 tag.

Would anyone be able to sanity-check if it works as expected before we release the main version?

charsleysa commented 1 year ago

Thanks @filipows

I'll be able to do a sanity check sometime this week as we've recently upgraded our apps to v15.

charsleysa commented 1 year ago

@filipows I've done a quick sanity check, the animations we use seem to be all working fine. Also deployed fine using a production build.

cwoebker commented 1 year ago

@filipows I can also confirm that the beta version works correctly for us with our Angular v15 application.

Flusinerd commented 1 year ago

Can confirm as well. Also angular 16 is scheduled to release this week image source