filippocastelli / pyometiff

OME-TIFF IO in python
GNU General Public License v3.0
19 stars 4 forks source link

missing metadata entries #15

Closed irelamb closed 3 months ago

irelamb commented 3 months ago

Hi Filippo,

thank you very much for your code, it's very useful. However I think some OME metadata entries are missing in your code, in particular 'TimeIncrement' and 'TimeIncrementUnit'. I would suggest to add them, they are important when dealing with time series.

Best, Irene

filippocastelli commented 3 months ago

Hey there!

It's very possible that I overlooked some metadata entries related to time series as I didn't work with them directly. I'll add TimeIncrement and TimeIncrementUnit asap, did you notice other missing fields that you might need?

Filippo

irelamb commented 3 months ago

Thank you for the prompt reply! Those are the only ones that I noticed, everything else seems fine to me.

filippocastelli commented 3 months ago

Hi Irene! Release 1.0.1 should support reading and writing TimeIncrement and TimeIncrementUnit metadata. to upgrade just run pip install --upgrade pyometiff let me know if you encounter any issues I'm closing the issue for now, but feel free to re-open another one if needed