search

filippocastelli / pyometiff

OME-TIFF IO in python
GNU General Public License v3.0
19 stars 4 forks source link

Don't list pytest and mock as install_requires. #8

Closed anntzer closed 1 year ago

anntzer commented 1 year ago

They are only needed in a dev environment, not for end users.

(Note that there are various ways in which one could avoid the duplication between install_requires and the requirements file, e.g. splitting out the dev requirements in a separate requirements file, but I just went for the simpler and more practical approach here.)

filippocastelli commented 1 year ago

Hi! Thanks a lot for the involvement. Yes, it would be best to include pytest and mock as extras, the setup.py should definetly have a dev extra, but I think it would be better to keep the main requirements as a textfile than hardcode its contents in setup.py.

filippocastelli commented 1 year ago

actually the setup already has a dev extra (had to check again), it's just that requirements needlessly duplicates those dependencies. What if we just removed those two lines from requirements?

anntzer commented 1 year ago

Works for me too; done.