filips123 / PWAsForFirefox

A tool to install, manage and use Progressive Web Apps (PWAs) in Mozilla Firefox
https://pwasforfirefox.filips.si
Mozilla Public License 2.0
2.27k stars 52 forks source link

"Use the manifest for determining app properties" checkbox does not appear on the PWA installation page for Old Reddit #485

Closed peldas closed 6 months ago

peldas commented 7 months ago

Description

"Use the manifest for determining app properties" checkbox does not appear on the PWA installation page for Old Reddit so I cannot install a functioning version of it (the app installs but PWAsForFirefox does not recognise it as a valid app to open pass Old Reddit links to from my standard Firefox installation).

Steps to Reproduce

  1. Go to https://old.reddit.com/
  2. Click the icon in the address bar
  3. Try to find the "Use the manifest for determining app properties" checkbox at the bottom
  4. It does not appear

Additional Information

image

Affected Websites

Old Reddit (required due to #61 and #71).

Environment

filips123 commented 7 months ago

Old Reddit's manifest is also broken, as it specifies https://www.reddit.com/ as scope and start URL. Because of that, the extension can't use it, so the checkbox is not displayed.

However, it appears that the latest Reddit redesign (the one at https://www.reddit.com/) now has a valid manifest. They "fixed" it by removing all shortcuts and most icons (and it seems they really want users to use their mobile app), but at least you should be able to install it. So, if you don't mind using the new design, you can try that.

I will try to make opening links work with websites without manifest in the future, but I think it will require quite a lot of changes, and I also don't have time currently, so it may take a while.

Also, summary of manifests of various Reddit "versions" and their issues:

filips123 commented 6 months ago

I will close this issue because it's a problem with (old) Reddit that I can't fix. I've updated the documentation in ada421c139e2b12d968d8a4b64e52ba066a9486c to mention that only the old Reddit now has issues.

I will probably make opening links work with websites without manifest in the future, but I don't know when.