search

filips123 / PWAsForFirefox

A tool to install, manage and use Progressive Web Apps (PWAs) in Mozilla Firefox
https://pwasforfirefox.filips.si
Mozilla Public License 2.0
2.25k stars 51 forks source link

The .desktop entry generated with a non-standard "WebApps" category on Linux #544

Closed Granitosaurus closed 1 month ago

Granitosaurus commented 2 months ago

Description

Currently the .desktop file generated contains invalid Categories entry:

Categories=GTK;WebApps;

This can be identified by using desktop-file-validate tool which reports:

❯ : desktop-file-validate ~/.local/share/applications/FFPWA-xxx.desktop 
/home/myuser/.local/share/applications/FFPWA-xxx.desktop: error: value "GTK;WebApps;" for key "Categories" in group "Desktop Entry" contains an unregistered value "WebApps"; values extending the format should start with "X-"

To fix this replacing WebApps with X-WebApps does the trick.

See freedesktop docs on available standard categories: https://specifications.freedesktop.org/menu-spec/latest/category-registry.html

Maybe WebApp should be replaced with standard Network category?

Granitosaurus commented 2 months ago

Seems like only 1 main category is allowed per desktop entry so using Network and user specified category (through extension, which is mandatory selection) is not allowed. So I think X-WebApp is best choice here or it should be removed entirely and only user's selection left there.

filips123 commented 2 months ago

I think I've added WebApps category because it was created by the Linux Mint's Webapp Manager. However, now that I checked it again, it seems they only provide this category as an option, and it's not always added like in PWAsForFirefox.

So, I think it should just be removed entirely, so only GTK and user categories are left.