search

filipst / hackerskeyboard

Automatically exported from code.google.com/p/hackerskeyboard
0 stars 0 forks source link

Serbian layout for portrait is not fully visible and landscape layout doesn't exist #133

Closed GoogleCodeExporter closed 9 years ago

GoogleCodeExporter commented 9 years ago 
First, the portrait layout is missing the key ђ. Actually, the key is not 
missing, it is the last key in the second row, but the second row has too many 
keys (one more than the first row) so that particular key gets left out.

To fix that I moved the 'ђ' key to the third row, after 'м' and before the 
backspace key.

Next, the landscape layout for Serbian doesn't even exist. Therefore I 
"translated" the donottranslate-keymap.xml file for Serbian layout.

Attached to this issue is the patch I made to fix the above issues. I hope 
you'll integrate them soon so that I don't have to compile the keyboard myself 
:)

Keep up the good work
Filip

Original issue reported on code.google.com by fbrcic on 24 Dec 2011 at 7:07

Attachments:

GoogleCodeExporter commented 9 years ago 
Thanks for your contribution, I should be able to integrate this in the next 
release.

Original comment by Klaus.We...@gmail.com on 26 Dec 2011 at 6:44

GoogleCodeExporter commented 9 years ago 
You are welcome. Thank you for the best keyboard for Android :)

Original comment by fbrcic on 26 Dec 2011 at 1:49

GoogleCodeExporter commented 9 years ago 
Merged as revision b932878cf2fd with some changes:

- removed the alternate (long-press) keys from the 5-row keyboard, these 
appeared unchanged from the original English layout and don't seem to 
correspond well to the mapped characters. Let me know if you want them added 
back or have other alternates for those positions - you can add characters 
directly to the *_alt strings, no need to use the alternates_for_* indirection.

- adjust the key width for the second-lowest row, the keys didn't fill the row 
completely. (Was the missing character there at some point and not moved 
correctly?)

I've uploaded a new binary, please try v1.28rc9 (or later) from 
http://code.google.com/p/hackerskeyboard/downloads/list and let me know if it 
works for you.

Original comment by Klaus.We...@gmail.com on 27 Dec 2011 at 7:42

GoogleCodeExporter commented 9 years ago 
Issue 135 has been merged into this issue.

Original comment by Klaus.We...@gmail.com on 27 Dec 2011 at 7:44

GoogleCodeExporter commented 9 years ago 
This works excellent. Thanks.

Here's how portrait looked like (no ђ wasn't even partially seen, at least not 
on my Galaxy S2):

https://photos-1.dropbox.com/i/l/Jpn3Wk-uL1u7ZcmDS87Y2jEfhN0WWFlqCTeP0sboAqs/844
580/1325070000/dc11be5/SC20111227-114547.png

and here is how portrait looks now:

https://photos-2.dropbox.com/i/l/uDq9jqAHO32QVWmLBlbDl-kpdlXxGq_Uhx90wxI-wBg/844
580/1325073600/c459c36/SC20111227-115950.png

and landscape:

https://photos-3.dropbox.com/i/l/keyGk9aCX8-Hybo-QXOGAZfpVXyIp61AubnJW5C-DQw/844
580/1325073600/48ed2ad/SC20111227-120006.png

If I find some glitch, I'll let you know. Great job.

Original comment by fbrcic on 27 Dec 2011 at 11:04

GoogleCodeExporter commented 9 years ago 
[Bulk bug update] The new Market release 1.29 includes the changes from the 
v1.28 prerelease series, and these "FixInTest" issues should now be fixed. If 
not, please reopen the bug with additional information. If the original bug 
covered multiple separate issues that aren't all addressed, please open new 
bug(s) for the leftover ones.

Original comment by Klaus.We...@gmail.com on 13 Jan 2012 at 9:29

GoogleCodeExporter commented 9 years ago 
Bulk update - changing "Fixed" to "Verified" for old bugs.

(Background: I'm changing the "Fixed" status to be considered open, the next 
steps in the lifecycle will be the closed states "FixInTest" and "Verified". 
This lets me mark issues as "Fixed" in commit messages without hiding them from 
the issue tracker.)

Original comment by Klaus.We...@gmail.com on 22 Jan 2013 at 7:33

GoogleCodeExporter commented 9 years ago 
Bulk update - changing "Fixed" to "Verified" for old bugs.

Original comment by Klaus.We...@gmail.com on 22 Jan 2013 at 7:34