search

filipst / hackerskeyboard

Automatically exported from code.google.com/p/hackerskeyboard
0 stars 0 forks source link

Various compose sequences are non-functional #96

Closed GoogleCodeExporter closed 9 years ago

GoogleCodeExporter commented 9 years ago 
For example, Compose 't' 'h'. This should produce 'þ'.

It's definitely something in 34b299e36f44 ('refactor compose and dead-key 
logic') which has caused this. I'm just not sure what, as yet.

Original issue reported on code.google.com by justanot...@googlemail.com on 20 Oct 2011 at 12:20

GoogleCodeExporter commented 9 years ago 
Got it: an off-by-one. The fix is in my 'upstream' branch, along with another 
fix which prevents a null dereference in the absence of isValidWordNative etc.

Original comment by justanot...@googlemail.com on 20 Oct 2011 at 7:58

GoogleCodeExporter commented 9 years ago 
This issue was closed by revision 0771124d745a.

Original comment by Klaus.We...@gmail.com on 20 Oct 2011 at 8:50

GoogleCodeExporter commented 9 years ago 
Thanks for the fix, I've merged it, and the one for the possible null pointer.

TODO(klausw): add regression tests, and/or some appropriate unit tests?

Original comment by Klaus.We...@gmail.com on 20 Oct 2011 at 8:55

GoogleCodeExporter commented 9 years ago 
I've included the fix in v1.26rc3, see 
http://code.google.com/p/hackerskeyboard/downloads/list

Original comment by Klaus.We...@gmail.com on 21 Oct 2011 at 12:40

GoogleCodeExporter commented 9 years ago 
Included in Market release v1.27.

Original comment by Klaus.We...@gmail.com on 7 Nov 2011 at 2:18

GoogleCodeExporter commented 9 years ago 
Bulk update - changing "Fixed" to "Verified" for old bugs.

(Background: I'm changing the "Fixed" status to be considered open, the next 
steps in the lifecycle will be the closed states "FixInTest" and "Verified". 
This lets me mark issues as "Fixed" in commit messages without hiding them from 
the issue tracker.)

Original comment by Klaus.We...@gmail.com on 22 Jan 2013 at 7:33

GoogleCodeExporter commented 9 years ago 
Bulk update - changing "Fixed" to "Verified" for old bugs.

Original comment by Klaus.We...@gmail.com on 22 Jan 2013 at 7:34