search

filipw / Strathweb.AspNetCore.AzureBlobFileProvider

MIT License
55 stars 22 forks source link

Directly return stream from CreateReadStream #21

Closed kdubau closed 2 years ago

kdubau commented 4 years ago

Fixes #18 ?

kdubau commented 4 years ago

@johnayling thoughts?

johnayling commented 4 years ago

I've used this way to download very large files from Azure without doubling up with a memory stream.

public async Task CreateReadStream() { var stream = await _blockBlob.OpenReadAsync(); return new FileStreamResult(stream, "application/octet-stream"); }

ibruynin commented 4 years ago

Curious if there is a way to test this pull request. There are no unofficial prerelease nugets available right?

ibruynin commented 2 years ago

@filipw - Quick note. I forked this change and it behaves well in production now. also fixes #18 - so it seems

kdubau commented 2 years ago

I'm closing this since the author never accepted it.