search

filipw / Strathweb.CacheOutput

ASP.NET Web API CacheOutput - library to allow you to cache the output of ApiControllers
Other
882 stars 253 forks source link

Update IApiOutputCache to Async signatures #224

Open Freakazoid182 opened 6 years ago

Freakazoid182 commented 6 years ago

Removes obsolete Get signature. Updates Core library to Framework 4.5 to better facilitate Task methods. IApiOutputCache usages and implementations are adjusted to use the updated interface.

This relates to the request to update the interface to have async signatures #158

I hope this is the approach you were aiming at.

sajibcefalo commented 6 years ago

When will be this pull request merged?

ErroneousFatality commented 6 years ago

@filipw Could you please comment if you plan on adding this functionality to your library or not, so we know whether to keep using it.

filipw commented 5 years ago

I think this is a good change - would you be so kind and rebase this on top of the latest master? I would normally like to avoid breaking changes too but I think this is OK in this case. Unfortunately when the original interface was created, Web API was sync only 😀

Freakazoid182 commented 5 years ago

Thanks for the review!

I'm not sure if I should've rebased this on master. Was this what you wanted? Let me know how you would like it. I branched off of dev, so it looks like this PR is now including some commits that are not part of this PR.

filipw commented 5 years ago

oops sorry I meant dev indeed 🙈😱

Freakazoid182 commented 5 years ago

oops sorry I meant dev indeed 🙈😱

Sorry about that too, I should've asked before I updated my branch.

All should be sorted now. Rebased on dev and comments resolved.

filipw commented 5 years ago

thanks a lot - before merging, I will set up CI for this project separately because the old one stopped working

djavier commented 5 years ago

Hi @filipw, any new status on this?