fillipe-gsm / python-tsp

Library to solve Traveling Salesperson Problems with pure Python code
MIT License
174 stars 28 forks source link

Replace logger with print #20

Closed FrickTobias closed 2 years ago

FrickTobias commented 2 years ago

See #19

In short, this

FrickTobias commented 2 years ago

Thanks for the feedback, I changed it according to your suggestions, except one case which I thought merited discussion.

In case of a warning, does it make sense to regulate it with the same argument as iteration prints? Maybe adding a silent mode for suppressing warnings (default False)? Or am I just overthinking this?

fillipe-gsm commented 2 years ago

In case of a warning, does it make sense to regulate it with the same argument as iteration prints? Maybe adding a silent mode for suppressing warnings (default False)? Or am I just overthinking this?

That is actually a good question. But in my opinion the gain in flexibility could overcomplicate what should be simple. I think we can consider all prints to be the same level, so we would have the rules:

What do you think?

FrickTobias commented 2 years ago

I agree. Simplicity is probably better here.

FrickTobias commented 2 years ago

Thank you again for sharing your code and actively maintaining it!

I think you'll have to merge though since I don't have write access to the repo!

Screen shot =>

Screen Shot 2022-07-27 at 9 55 58
fillipe-gsm commented 2 years ago

Thank you again for sharing your code and actively maintaining it!

I think you'll have to merge though since I don't have write access to the repo!

Screen shot => Screen Shot 2022-07-27 at 9 55 58

That's odd; I was sure an approval from an admin would be enough :confused: I'll look into that later. For now, I merged the PR.

Thanks again for the work!