Closed FrickTobias closed 2 years ago
Thanks for the feedback, I changed it according to your suggestions, except one case which I thought merited discussion.
In case of a warning, does it make sense to regulate it with the same argument as iteration prints? Maybe adding a silent mode for suppressing warnings (default False
)? Or am I just overthinking this?
In case of a warning, does it make sense to regulate it with the same argument as iteration prints? Maybe adding a silent mode for suppressing warnings (default
False
)? Or am I just overthinking this?
That is actually a good question. But in my opinion the gain in flexibility could overcomplicate what should be simple. I think we can consider all prints to be the same level, so we would have the rules:
verbose
is True
, print everything to the stdout. If False
, print nothing, even the warnings.What do you think?
I agree. Simplicity is probably better here.
Thank you again for sharing your code and actively maintaining it!
I think you'll have to merge though since I don't have write access to the repo!
Screen shot =>
Thank you again for sharing your code and actively maintaining it!
I think you'll have to merge though since I don't have write access to the repo!
Screen shot =>
That's odd; I was sure an approval from an admin would be enough :confused: I'll look into that later. For now, I merged the PR.
Thanks again for the work!
See #19
In short, this
logger.info()
withprint()
andlogger.warning()
withprint("WARNING: ")
logger.info()
/logger.warning()
only forlog_file
writing