search

filliph / ItemUpgradeTip

5 stars 3 forks source link

Incorrectly shows the amount of resources for "Double Time" #27

Open DanzoGit opened 5 months ago

DanzoGit commented 5 months ago

Description

I was expecting the correct amount of resources to improve to be shown, instead of the wrong amount.

P.S. Maybe something similar happens with other things, but so far I've only noticed the problem with this item.

World of Warcraft Flavor

Retail (Default)

ItemUpgradeTip Version

3.2.0

Tested with only ItemUpgradeTip

Yes

Reproduction Steps

  1. Trying to improve "Double Time" - https://www.wowhead.com/item=207991
  2. We see an incorrect number of resources that the addon shows us.

Lua Error

No response

Screenshots

screens ![WoWScrnShot_011924_180221](https://github.com/filliph/ItemUpgradeTip/assets/61109303/ceb9e60b-d252-4a21-bd4b-a18ff03ed537) ![WoWScrnShot_011924_180303](https://github.com/filliph/ItemUpgradeTip/assets/61109303/4b82c805-5814-44c1-bd9d-84ab686fd9b3) ![WoWScrnShot_011924_180307](https://github.com/filliph/ItemUpgradeTip/assets/61109303/623c6140-c36d-4210-8b0c-20c1502d6e29) ![WoWScrnShot_011924_180311](https://github.com/filliph/ItemUpgradeTip/assets/61109303/9e8d2737-d105-4036-a4c9-8b3c2cf4d793) ![WoWScrnShot_011924_180315](https://github.com/filliph/ItemUpgradeTip/assets/61109303/50236611-e50e-4a7c-8e91-9addd0d69149) ![WoWScrnShot_011924_180318](https://github.com/filliph/ItemUpgradeTip/assets/61109303/397a80d3-4fc7-4547-a208-b564655da3a7) ![WoWScrnShot_011924_180321](https://github.com/filliph/ItemUpgradeTip/assets/61109303/655f52f9-a6ca-491e-adcd-955b53c59195)
filliph commented 5 months ago

This is because of the discount system for dual-wielding. Unfortunately this is not communicated to add-ons through the API, so "best guess" is needed.

As of right now it can't really be fixed, unless a new method of detecting the discount is discovered.