filllabs / dependi

Dependi (formerly crates)
https://dependi.io
100 stars 7 forks source link

Support for pyproject.toml #12

Closed mrijken closed 1 month ago

mrijken commented 1 month ago

Is your feature request related to a problem? Please describe. I do not use requirement.txt for managing dependencies. I use Poetry with pyproject.toml

Describe the solution you'd like Support for pyproject.toml

Describe alternatives you've considered

Additional context Usage of requirements.txt is declining

serayuzgur commented 1 month ago

Seems like good idea @MOzanGul we can plan it

JP-Ellis commented 1 month ago

I would like to expand on @mrijken's initial comment, as the Python ecosystem has 2 (and a bit) standards:

The new standard: pyproject.toml

The pyproject.toml specification was created in PEP 621 and the most up to date specification is described in the packaging docs.

The Poetry caveat

Poetry uses pyproject.toml, but predates PEP 621, and therefore does not confirm to it. Having said that, Poetry v2 will support the new standard. See this roadmap ticket, and this draft PR implementing it. I don't know whether it is worth supporting Poetry's own standard, or encourage users to migrate the PEP 621 (and that would be a decision for Dependi).

The older standard: requirements.txt

This is the historical standard, and is still frequently used especially when pinning dependencies to specific version (since there is no standard lockfile yet). A common pattern will be to have very broad specifications in the pyproject.toml (so broad as to sometimes not have any version requirements), and the pinning specific versions of all dependencies in a requirements.txt file.

The specification is described in PEP 508

MOzanGul commented 1 month ago

Hi, per your request we have added the support for pyproject.toml in our new 0.7.5 version. We hope you like using our extension with this file type. We'd be really happy if you could review Dependi in VS Code Marketplace. Here is our reviews page. @JP-Ellis @mrijken

JP-Ellis commented 1 month ago

Thanks, I can confirm it works! I did notice a couple of minor issues, though I will post that in separate issues 👍

mrijken commented 1 month ago

Thanks, It works great. I have added a review.