search

fillmaster / fillMaster

FillMaster: A drum idea generator / improvisation trainer! - Open Source, always looking for more contributors :)
https://fillmaster.app/
GNU General Public License v3.0
31 stars 7 forks source link

Add an option to change fill type every 4 bars #13

Open dcallus opened 2 years ago

dcallus commented 2 years ago

There should be an on/off switch (or similar, see mui libary) to enable/disable, regeneration of the fill type, every 4 bars.

It is currently disabled as the feature is not present.

When enabled, the fill type (e.g. more hats, less hats) will change every 4 bars or 8 bars for example.

travor-k commented 2 years ago

Are you envisioning this as something that is adjustable from the settings page/tab or within the stepper?

dcallus commented 2 years ago

Are you envisioning this as something that is adjustable from the settings page/tab or within the stepper?

I think setting it from the settings for now would be best. I want to avoid adding stuff to the stepper if possible unless I've got good reason to. I'd like to keep it as 5 steps. I'll try and do some wireframes at some point for future features.

For now here's a rough sketch of what I was thinking:

Screenshot 2022-06-02 at 09 40 58

I realise this is a little more than described in the issue, but the full feature would probably look something like this. Potentially with the option to change between 4 and 8 bars (which would apply to both fill type and fill start options).

Something like this but open to suggestions.

You could simplify it a bit so there are only two options, static or 'cycle fill type every 4 bars' or just remove the 'alternate' feature which would be a bit more advanced. That would be enough for now, but I thought I'd let you know the full thinking.

When the fill type or fill start reset, it's probably best to re-run the randomiser animation so that the user has feedback that they are changing. They'd have to run a bar early or so, so that the result is ready for the correct bar and the user has plenty of time to read and think about the result, but I haven't thought this through completely how it will look. Something visual on the screen to say 'hey, time to change your fill style'. Perhaps a countdown...