fillmaster / fillMaster

FillMaster: A drum idea generator / improvisation trainer! - Open Source, always looking for more contributors :)
https://fillmaster.app/
GNU General Public License v3.0
31 stars 7 forks source link

Make sure fillStarts cannot be greater than beatsPerBar but go up to as high as beatsPerBar (e.g. fill on beat 5 in 5/4 but no fill on beat 4 in 3/4) #18

Closed dcallus closed 2 years ago

dcallus commented 2 years ago

No hardcoding. Whatever the time sig is on will be used. Possibly fill start on beat 8.

dcallus commented 2 years ago

This needs to be its own separate issue now. Much bigger deal than I expected. The problem is that the randomiser chooses a fill start position (e.g. 1 - 4) BEFORE the time signature has been chosen.

The problem with this should be obvious. You cannot base the maximum fill start position before you have set the number of beats per bar.

You could potentially default to 4/4 and have the time signature changer in the settings and this would force a restart of the app. But it's fun to play with time signatures without having to start from scratch.

I propose either of these options: a) instead on step one (to avoid adding a new step) - rename it to 'choose a tempo and time signature' where it is defaulted to 4/4. This might need some more difficult stage management. b) Default to 4/4 hardcoded (for now, could have options in settings eventually) but still able to change time signature once app is started. This would mean that changing the time signature top (number of beats) would force a restart of the randomiser. This would also be less clutter for the user. Would rely on issue 4 being done first.

dcallus commented 2 years ago

complete