fillmaster / fillMaster

FillMaster: A drum idea generator / improvisation trainer! - Open Source, always looking for more contributors :)
https://fillmaster.app/
GNU General Public License v3.0
31 stars 7 forks source link

Epic: Exact tempo & Tap Tempo #24

Open dcallus opened 2 years ago

dcallus commented 2 years ago

FOR NINAD

UI stuff for Dan

Stretch goal 1. Try having two tap tempo buttons lowest tempo and highest tempo on tempo range mode. See if it looks okay or is too convoluted. Stretch goal 2. Have an audio preview of the tempo on slider drag. Stretch goal 3. Add Italian tempo names depending on the chosen tempo or tempo range. Stretch goal 4. Add currently chosen settings to local storage. Stretch goal 5: A dial knob on the metronome to adjust tempo during playback.

dcallus commented 2 years ago

The app is due a re-design from the ground-up, but it's probably best to get this feature up first as the redesign will take time.

So go with something like the following design for now which fits into the current design.

proposed_1

dcallus commented 1 year ago

@ninad-d - edit: okay. I updated the epic branch to contain a new base class above pattern (see #56 ). There is now also a new class called TempoPreview. You won't need this straight away, but eventually you will.

I've rewritten this issue to clean it up a bit so that your section is separate from the UI and I'll do the UI stuff. Let me know if you have any questions.

For an example of a good tap tempo see the free app: The Metronome by SoundBrenner (iOS and Android) install and click 'Player' on the bottom.