search

fillmaster / fillMaster

FillMaster: A drum idea generator / improvisation trainer! - Open Source, always looking for more contributors :)
https://fillmaster.app/
GNU General Public License v3.0
31 stars 7 forks source link

added local storage for lower and upper tempo limits (#14) #25

Closed ricci2511 closed 2 years ago

ricci2511 commented 2 years ago

This should be enough to solve issue #14. Feedback is appreciated if something should be changed.

ricci2511 commented 2 years ago

Thanks so much for your contribution :) really appreciate it.

If we were to add multiple user options to the local storage, e.g. also time signature preferences and whatnot. Would you store them all into one big user object? Or just keep them all separate?

My pleasure, i'll gladly help when im able to.

It probably depends on how many options you're looking to add, but I guess a user object would be cleaner and easier to maintain in case you want to add more options in the future.