search

fillmaster / fillMaster

FillMaster: A drum idea generator / improvisation trainer! - Open Source, always looking for more contributors :)
https://fillmaster.app/
GNU General Public License v3.0
31 stars 7 forks source link

Add local storage for time signature and reset option #27

Closed dcallus closed 2 years ago

dcallus commented 2 years ago

Please add local storage options for time signatures so that the user's preference is saved. Follow practices in PR#25https://github.com/fillmaster/fillMaster/pull/25

Rename the RESET TO DEFAULTS button in the settings menu to 'RESET ALL SETTINGS' and make it apply to the play settings (as well as those already reset in the settings menu). i.e. make sure it also:

  1. Resets tempo slider to 60 - 120
  2. Resets time signature to 4/4
ricci2511 commented 2 years ago

@dcallus Hi again, since I did the previous LocalStorage issue I think I could look into this too. From my understanding you have a DEFAULTS object in App.tsx and a resetAllSettings function to reset to those values. Should I add a tempo slider and time signature key value pair in that DEFAULTS object and handle its reset in the resetAllSettings function?

That would be one solution to the problem, but I'm not sure if you have something else in mind.

dcallus commented 2 years ago

Hmmm. I'm not sure actually. I'll have a think tomorrow and let you know. Thanks for asking.

kristersd commented 2 years ago

@dcallus I have added an PR recently, storing in DEFAULTS would not make sense, as they are defaults for the drawer itself. I have implemented reset settings with an custom event, which I guess is the best solution, without refactoring a lot of the app, and moving to global state.

dcallus commented 2 years ago

Thanks @chrisd1999

Looks great. I'll have a proper look tomorrow. I need to go to bed shortly as its around midnight here in Scotland, can't believe how busy it's been today with everyone chipping in :)

Thanks so much for your contribution.

edit: managed to to get my branch stuff working :)