search

fillmaster / fillMaster

FillMaster: A drum idea generator / improvisation trainer! - Open Source, always looking for more contributors :)
https://fillmaster.app/
GNU General Public License v3.0
31 stars 7 forks source link

added landscape not supported message on mobile #28

Closed safin-sys closed 2 years ago

dcallus commented 2 years ago

@safin-sys - Hi there

I've just temporarily reverted this due to the fact that 'Landscape mode not available' pops up briefly on my desktop (mac - brave browser). Doesn't seem to be a problem on my mobile.

Otherwise it's great. Do you have a fix in mind?

Thanks

safin-sys commented 2 years ago

This is happening because the CSS is loading after HTML, this can be prevented by putting the CSS directly in index.html. If you have a better fix in mind lmk.

dcallus commented 2 years ago

This is happening because the CSS is loading after HTML, this can be prevented by putting the CSS directly in index.html. If you have a better fix in mind lmk.

This makes sense. Thanks.

I've remerged the branch and added the css to the head of index.html. Seems like a fine solution to me as it's not a huge amount of code to have here.

Thanks a lot :)