search

fillmaster / fillMaster

FillMaster: A drum idea generator / improvisation trainer! - Open Source, always looking for more contributors :)
https://fillmaster.app/
GNU General Public License v3.0
31 stars 7 forks source link

fixes broken code issue for pattern #52

Closed ninad-d closed 2 years ago

ninad-d commented 2 years ago

@dcallus i tried my best to fix it. The Pattern class does not has playOn property as part of it because it does not needs to deal with it. The MetronomePattern has the PlayHelperOn property because it actually makes use of it.

So what I got rid of the changes for IPatternHelperSettings and added a property that deals with PlayHelperOn in MetronomePattern.

The code compiles and you get an output.

Not sure if its the right way todo it cause I am yet to get handle on the nuances of Pattern and its purpose.

Please review.

dcallus commented 2 years ago

@ninad-d That's the action runner set up now. So hopefully this won't be an issue again. Test failures will be flagged straight away :)