search

fillmaster / fillMaster

FillMaster: A drum idea generator / improvisation trainer! - Open Source, always looking for more contributors :)
https://fillmaster.app/
GNU General Public License v3.0
31 stars 7 forks source link

Change tests to typescript #7

Closed dcallus closed 2 years ago

dcallus commented 2 years ago

The current tests in the test folder are in JavaScript as mocha is a js framework. Find an alternative as it sucks to lose type safety. Perhaps use chai with mocha?

dcallus commented 2 years ago

ts-jest is the solution. It won't require basically any changes to the tests.

Have an experimental branch feature/typescript-test but it's not working yet, it seems to be conflicting with the tests that are added automatically by create-react-app boilerplate.

dcallus commented 2 years ago

Done.. However the react-pro-metronome tests have been temporarily removed. These will need to be reinstated before any changes (e.g. updated to typescript) to react-pro-metronome fork are done.