search

film42 / pgreba

A health-checking service for postgres
2 stars 5 forks source link

Multi-hop health-checking #18

Closed film42 closed 2 years ago

film42 commented 3 years ago

We didn't enable multi-hop health-checking to reduce the connection amplification caused by many concurrent health-checks. However, since we added the 1-second health-check cache in #13 , I wonder if we should enabled a max-hop setting and recursively hop from postgres server to postgres server until we've found the primary.

Thoughts @benschinn ?

schinns commented 3 years ago

Sounds good. @film42 should we set the max-hop setting in the config?

film42 commented 3 years ago

I think so! We can also start with hard-coding to 3 hops to support the MX use-case first and add configuration later if it makes more sense. Up to you!