search

film42 / pgreba

A health-checking service for postgres
2 stars 5 forks source link

Print error and don't exit #29

Closed schinns closed 3 years ago

schinns commented 3 years ago

We are seeing this error occur:

Error getting pg_current_wal_lsn: sql: no rows in resulting set

Then pgreba exits with status 1.

Removing Fatalln should fix this issue.

cc: @skunkworker @film42

schinns commented 3 years ago

got rid of the superfluous writing to header. tested in sand.

Before:

Aug 03 21:21:46 sb-sand-postgres101 pgreba[26816]: 2021/08/03 21:21:46 http: superfluous response.WriteHeader call from github.com/gorilla/handlers.(*responseLogger).WriteHeader (handlers.go:65)
Aug 03 21:21:46 sb-sand-postgres101 pgreba[26816]: 10.47.33.194 - - [03/Aug/2021:21:21:46 +0000] "GET /replica?max_allowable_byte_lag=200000000 HTTP/1.0" 503 419
Aug 03 21:21:48 sb-sand-postgres101 pgreba[26816]: 2021/08/03 21:21:48 http: superfluous response.WriteHeader call from github.com/gorilla/handlers.(*responseLogger).WriteHeader (handlers.go:65)
Aug 03 21:21:48 sb-sand-postgres101 pgreba[26816]: 10.47.33.194 - - [03/Aug/2021:21:21:48 +0000] "GET /replica?max_allowable_byte_lag=200000000 HTTP/1.0" 503 419
Aug 03 21:21:48 sb-sand-postgres101 pgreba[26816]: 2021/08/03 21:21:48 http: superfluous response.WriteHeader call from github.com/gorilla/handlers.(*responseLogger).WriteHeader (handlers.go:65)
Aug 03 21:21:48 sb-sand-postgres101 pgreba[26816]: 10.47.33.195 - - [03/Aug/2021:21:21:48 +0000] "GET /replica?max_allowable_byte_lag=200000000 HTTP/1.0" 503 419
Aug 03 21:21:48 sb-sand-postgres101 pgreba[26816]: 10.47.33.195 - - [03/Aug/2021:21:21:48 +0000] "GET /primary HTTP/1.0" 200 419

Fixed:

Aug 03 21:23:52 sb-sand-postgres101 pgreba[25915]: 2021/08/03 21:23:52 Listening on :8000
Aug 03 21:23:52 sb-sand-postgres101 pgreba[25915]: 10.47.33.195 - - [03/Aug/2021:21:23:52 +0000] "GET /replica?max_allowable_byte_lag=200000000 HTTP/1.0" 503 419
Aug 03 21:23:52 sb-sand-postgres101 pgreba[25915]: 10.47.33.194 - - [03/Aug/2021:21:23:52 +0000] "GET /replica?max_allowable_byte_lag=200000000 HTTP/1.0" 503 419
Aug 03 21:23:52 sb-sand-postgres101 pgreba[25915]: 10.47.33.195 - - [03/Aug/2021:21:23:52 +0000] "GET /primary HTTP/1.0" 200 419
Aug 03 21:23:52 sb-sand-postgres101 pgreba[25915]: 10.47.33.194 - - [03/Aug/2021:21:23:52 +0000] "GET /primary HTTP/1.0" 200 419
Aug 03 21:23:54 sb-sand-postgres101 pgreba[25915]: 10.47.33.194 - - [03/Aug/2021:21:23:54 +0000] "GET /replica?max_allowable_byte_lag=200000000 HTTP/1.0" 503 419
Aug 03 21:23:54 sb-sand-postgres101 pgreba[25915]: 10.47.33.195 - - [03/Aug/2021:21:23:54 +0000] "GET /replica?max_allowable_byte_lag=200000000 HTTP/1.0" 503 419
Aug 03 21:23:54 sb-sand-postgres101 pgreba[25915]: 10.47.33.194 - - [03/Aug/2021:21:23:54 +0000] "GET /primary HTTP/1.0" 200 419
Aug 03 21:23:54 sb-sand-postgres101 pgreba[25915]: 10.47.33.195 - - [03/Aug/2021:21:23:54 +0000] "GET /primary HTTP/1.0" 200 419
Aug 03 21:23:56 sb-sand-postgres101 pgreba[25915]: 10.47.33.194 - - [03/Aug/2021:21:23:56 +0000] "GET /replica?max_allowable_byte_lag=200000000 HTTP/1.0" 503 419
Aug 03 21:23:56 sb-sand-postgres101 pgreba[25915]: 10.47.33.195 - - [03/Aug/2021:21:23:56 +0000] "GET /replica?max_allowable_byte_lag=200000000 HTTP/1.0" 503 419
Aug 03 21:23:56 sb-sand-postgres101 pgreba[25915]: 10.47.33.195 - - [03/Aug/2021:21:23:56 +0000] "GET /primary HTTP/1.0" 200 419
Aug 03 21:23:56 sb-sand-postgres101 pgreba[25915]: 10.47.33.194 - - [03/Aug/2021:21:23:56 +0000] "GET /primary HTTP/1.0" 200 419
Aug 03 21:23:58 sb-sand-postgres101 pgreba[25915]: 10.47.33.194 - - [03/Aug/2021:21:23:58 +0000] "GET /replica?max_allowable_byte_lag=200000000 HTTP/1.0" 503 419
Aug 03 21:23:58 sb-sand-postgres101 pgreba[25915]: 10.47.33.194 - - [03/Aug/2021:21:23:58 +0000] "GET /primary HTTP/1.0" 200 419
Aug 03 21:23:58 sb-sand-postgres101 pgreba[25915]: 10.47.33.195 - - [03/Aug/2021:21:23:58 +0000] "GET /replica?max_allowable_byte_lag=200000000 HTTP/1.0" 503 419
Aug 03 21:23:58 sb-sand-postgres101 pgreba[25915]: 10.47.33.195 - - [03/Aug/2021:21:23:58 +0000] "GET /primary HTTP/1.0" 200 419
Aug 03 21:24:00 sb-sand-postgres101 pgreba[25915]: 10.47.33.194 - - [03/Aug/2021:21:24:00 +0000] "GET /replica?max_allowable_byte_lag=200000000 HTTP/1.0" 503 419
Aug 03 21:24:00 sb-sand-postgres101 pgreba[25915]: 10.47.33.195 - - [03/Aug/2021:21:24:00 +0000] "GET /primary HTTP/1.0" 200 419
Aug 03 21:24:00 sb-sand-postgres101 pgreba[25915]: 10.47.33.194 - - [03/Aug/2021:21:24:00 +0000] "GET /primary HTTP/1.0" 200 419
Aug 03 21:24:00 sb-sand-postgres101 pgreba[25915]: 10.47.33.195 - - [03/Aug/2021:21:24:00 +0000] "GET /replica?max_allowable_byte_lag=200000000 HTTP/1.0" 503 419
Aug 03 21:24:02 sb-sand-postgres101 pgreba[25915]: 10.47.33.195 - - [03/Aug/2021:21:24:02 +0000] "GET /replica?max_allowable_byte_lag=200000000 HTTP/1.0" 503 419
Aug 03 21:24:02 sb-sand-postgres101 pgreba[25915]: 10.47.33.195 - - [03/Aug/2021:21:24:02 +0000] "GET /primary HTTP/1.0" 200 419
Aug 03 21:24:02 sb-sand-postgres101 pgreba[25915]: 10.47.33.194 - - [03/Aug/2021:21:24:02 +0000] "GET /primary HTTP/1.0" 200 419
Aug 03 21:24:02 sb-sand-postgres101 pgreba[25915]: 10.47.33.194 - - [03/Aug/2021:21:24:02 +0000] "GET /replica?max_allowable_byte_lag=200000000 HTTP/1.0" 503 419
ETetzlaff commented 3 years ago

LGTM