film42 / sidekiq-rs

A port of sidekiq to rust using tokio
MIT License
95 stars 10 forks source link

making simple-process-stats optional #33

Closed jondot closed 7 months ago

jondot commented 7 months ago

Hi, There is a dependency issue, which causes unresolvable Cargo conflicts on macOS caused by a transitive dependency of simple-process-stats:

since simple_process_stats use by sidekiq-rs is minimal only for getting RSS, its better to replace it with something that has more velocity on updating dependencies but that is also lightweight and cross platform (I didn't find one yet).

in the meanwhile as a workaround, I put the dependency under an optional flag -- enabled by a feature. this feature is by-default turned on so no one will notice.

in our codebase, we can disable this feature, which disables simple-process-stats, and our build passes nicely.

film42 commented 7 months ago

Looks great. Going to add a comment at the cfg to state why and under what conditions this can be removed. Thank you!

film42 commented 7 months ago

Released as 0.8.2.