search

filmil / bazel-bats

bazel-bats: bazel test rules for the BATS testing framework (based on bats-core)
Apache License 2.0
10 stars 4 forks source link

Adding Optional bats-core Extensions #10

Closed qec-pconner closed 1 year ago

qec-pconner commented 2 years ago

Extending bazel_bats_dependencies() to also (optionally) allow for adding in bats extensions, bats-assert and bats-support (bats-support is required for bats-assert).

The decision to make these optional additions was made to not force extra dependencies on any downstream library that does not make use of them (dep management is good). The bats_test() rule will be updated in a follow-up PR.

Merge this PR after https://github.com/filmil/bazel-bats/pull/9 (diff will also be easier to read once that PR is merged). Merge this PR before https://github.com/filmil/bazel-bats/pull/11.

Submitting as separate PRs to more easily see what is changing. :smile:

qec-pconner commented 1 year ago

This PR is mostly good to go -- though I would like to first merge master back in after https://github.com/filmil/bazel-bats/pull/9 has been merged to get a nice clean diff. :)

qec-pconner commented 1 year ago

Ok. This PR should now be good to go.

filmil commented 1 year ago

Care to rebase?

filmil commented 1 year ago

Hm, still conflicting.

qec-pconner commented 1 year ago

Care to rebase?

Done. Merged from master (I don't rebase with PR reviews as GitHub annoyingly tosses out old blobs).

qec-pconner commented 1 year ago

Hm, still conflicting.

image 🤷

qec-pconner commented 1 year ago

Not sure how the project is set up, but squashing may be necessary on merge. Sorry, not sure where the conflict is.

filmil commented 1 year ago

Looking.