filoe / cscore

An advanced audio library, written in C#. Provides tons of features. From playing/recording audio to decoding/encoding audio streams/files to processing audio data in realtime (e.g. applying custom effects during playback, create visualizations,...). The possibilities are nearly unlimited.
Other
2.14k stars 450 forks source link

DmoMp3Decoder incorrectly Dispose the stream #452

Open fabri9532 opened 3 years ago

fabri9532 commented 3 years ago

If I create a DmoMp3Decoder with a filename it is correct for DmoMp3Decoder to dispose the stream because it is opened by DmoMp3Decoder.

If I create a DmoMp3Decoder passing a stream as constructor argument, DmoMp3Decoder should not dispose the stream as it was created externally. Instead in CSCore v1.2.1.2 DmoMp3Decoder dispose the stream even if passed as an argument to the constructor.