search

filosganga / geogson

GeoJSON support for Google gson library
Apache License 2.0
69 stars 28 forks source link

handle JTS geometries that are null or empty correctly and do not check lon and lat of Coordinates supporting also metric CRS #29

Closed bkiselka closed 10 years ago

bkiselka commented 10 years ago

28 by mistake reverted #27 and #26

1) JtsAdapterFactory and JtsAdapterFactoryTest: handle JTS geometries that are null or empty correctly (i.e contain no coordinates) correctly (same idea as in lurajon@877b13c )

2) Coordinates and CoordinatesTest: do not check lon and lat parameters in constructor of Coordinates supporting also metric CRS (Coordinate Reference Systems):

define lon and lat like in OpenLayers (see constructor http://dev.openlayers.org/releases/OpenLayers-2.13.1/doc/apidocs/files/OpenLayers/BaseTypes/LonLat-js.html ) allowing alternative map units (kilometer, meter, mile, foot and inch) additional to degree (idea from http://dev.openlayers.org/releases/OpenLayers-2.13.1/doc/apidocs/files/OpenLayers/Map-js.html#OpenLayers.Map.units )

filosganga commented 10 years ago

@bkiselka Thanks for your huge support, feel free to add yourself to the list of contributors.

bkiselka commented 10 years ago

Thanks! Lets see what else is out there during use in production (thanks again for the new version!!)...

filosganga commented 10 years ago

Good to know it is used in production anywhere...make me proud.

On 27 October 2014 18:28, Bernhard Kiselka notifications@github.com wrote:

Thanks! Lets see what else is out there during use in production (thanks again for the new version!!)...

— Reply to this email directly or view it on GitHub https://github.com/filosganga/geogson/pull/29#issuecomment-60644693.

Filippo De Luca

WWW: http://filippodeluca.com IM: filosganga80@gmail.com