search

filosganga / geogson

GeoJSON support for Google gson library
Apache License 2.0
68 stars 29 forks source link

#65: updated to latest JTS with package name change #66

Closed smirnovegorv closed 5 years ago

smirnovegorv commented 5 years ago

Updated JTS to latest 1.16.0 version with dependency name change (was com.vividsolutions.jts but from 1.15.0 it is org.locationtech.jts).

Updated version to 2.0 since this is a breaking change.

See https://github.com/locationtech/jts/blob/master/MIGRATION.md

neseleznev commented 5 years ago

Hi @filosganga. Thanks for this awesome library! Do you plan to merge this PR and roll 2.0 out?

P.S. Unfortunately, this blocks Hibernate upgrade to 5.4.x and beyond

filosganga commented 5 years ago

@neseleznev It does not seem to build in CI

smirnovegorv commented 5 years ago

CI reports looks a bit weird to me, there are no errors and no tests were run and it says like "The forked VM terminated without properly saying goodbye. VM crash or System.exit called?". Could you re-run the tests manually?

As for myself, I am using this version for quite a while already and everything seems fine. Tests also pass on my PC

filosganga commented 5 years ago

I see, let me try to kick off it again.

filosganga commented 5 years ago

The issue isn't in the PR itself, but I need to fix it to be able to release

svbrunov commented 4 years ago

Dear Filippo De Luca (@filosganga),

It seems that this version that contains these changes has not been released yet.
Could you please release it?

It would be great to have this version published into the Maven Central Repository.

Best regards,
Sergey Vyacheslavovich Brunov.

filosganga commented 4 years ago

Yes sure, will do this weekend thanks

On Sat, 30 May 2020, 17:33 Sergey Brunov, notifications@github.com wrote:

Hi, @filosganga https://github.com/filosganga!

It seems that this version that contains these changes has not been released yet. Could you please release it?

It would be great to have this version published into the Maven Central Repository.

Best regards, Sergey Brunov.

— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub https://github.com/filosganga/geogson/pull/66#issuecomment-636354631, or unsubscribe https://github.com/notifications/unsubscribe-auth/AAA2Q56TVMORM72A2EU4IILRUEYPHANCNFSM4GTJ757A .

svbrunov commented 4 years ago

Dear Filippo De Luca (@filosganga),

It sounds great!
Thank you very much for the prompt response and support!

Best regards,
Sergey Vyacheslavovich Brunov.

svbrunov commented 4 years ago

Dear Filippo De Luca (@filosganga),

Could you please share the status of the work on the release?
May I help you somehow?

Best regards,
Sergey Vyacheslavovich Brunov.

svbrunov commented 2 years ago

Dear Filippo De Luca (@filosganga),

Thank you for providing the 1.4.31 release!

Just for your information. I have successfully upgraded the version of the geogson Maven dependencies from 1.4.2 to 1.4.31 for one of my projects.

Best regards, Sergey Vyacheslavovich Brunov.