search

filox / StormCpp

A small C++ wrapper for Storm
31 stars 9 forks source link

Compatibility with storm 0.9.0.1 #6

Open Alien2150 opened 10 years ago

Alien2150 commented 10 years ago

Hi,

i think the current stormcpp is not compatible with storm 0.9.0.1 as sending the task ids is optional (See the handleEmit method, especial the "need_task_ids" part in https://github.com/apache/incubator-storm/blob/master/storm-core/src/jvm/backtype/storm/task/ShellBolt.java ). The C++ Code is always expecting it to send the task-ids. The best solution i can think of here is to add an extra parameter to the emit method so that reading of task-ids is optional. I can provide a pull request if that is prefered.

Alien2150 commented 10 years ago

here is possible patch:

https://gist.github.com/Alien2150/20fa4bd5f197aa5c3c3b

filox commented 10 years ago

Thanks for looking into this! I don't really have much time to maintain this project any more. Do you want to push this change?