search

filp / whoops

PHP errors for cool kids
http://filp.github.io/whoops/
MIT License
13.17k stars 602 forks source link

Correct vscode open links #761

Closed andrewnicols closed 10 months ago

andrewnicols commented 10 months ago

The format of links for vscode is currently set to:

vscode://file/{$file}:{$line}

This leads to URIs such as:

vscode://file//Users/example/git/example.php

However vscode expects URIs in the format:

vscode://file/Users/example/git/example.php

That is to say that the URI should be immediately after the file.

The correct URI format is:

vscode://file{$file}:{$line}

See https://github.com/microsoft/vscode/issues/197319 for more information.

denis-sokolov commented 10 months ago

It seems like this change is not needed after all: https://github.com/microsoft/vscode/issues/198509#issuecomment-1816205881.