search

filso / ng-dependency-graph

AngularJS dependency browser for Chrome
http://angularjs-graph.org
MIT License
267 stars 23 forks source link

Showing modules and components on the same graph #9

Open chiptus opened 8 years ago

chiptus commented 8 years ago

Great tool, very helpful to see my app this way. As the title says, would be really nice to see modules and components together, I really like to know how components from different modules connected to each others (through their modules of course)

Thanks!

filso commented 8 years ago

Hi @chiptus. Thank you for feedback. Idea seems very nice, but I'm not sure how that would look like..

Modules contain components, so to visualise it we'd have to draw some kind of containers (modules) for nodes (components).

With current implementation (force graph), I don't see how that could possibly work

chiptus commented 8 years ago

are you working with d3? I work with it on my project. If so, I'll try to think of a way

On Sun, Jan 3, 2016 at 3:17 PM Filip Sobczak notifications@github.com wrote:

Hi @chiptus https://github.com/chiptus. Thank you for feedback. Idea seems very nice, but I'm not sure how that would look like..

Modules contain components, so to visualise it we'd need some kind of containers (modules) for nodes (components).

With current implementation (force graph), I don't see how that could possibly work

— Reply to this email directly or view it on GitHub https://github.com/filso/ng-dependency-graph/issues/9#issuecomment-168497075 .

filso commented 8 years ago

Yes, it's d3. Thanks

chiptus commented 8 years ago

Was thinking of something similar to this: http://bl.ocks.org/GerHobbelt/3071239

I'll be happy to play with the code and PR when i implement it

On Wed, Jan 6, 2016 at 12:28 PM Filip Sobczak notifications@github.com wrote:

Yes, it's d3. Thanks

skype: fsobczak http://filso.net

On 3 January 2016 at 19:02, chiptus notifications@github.com wrote:

are you working with d3? I work with it on my project. If so, I'll try to think of a way

On Sun, Jan 3, 2016 at 3:17 PM Filip Sobczak notifications@github.com wrote:

Hi @chiptus https://github.com/chiptus. Thank you for feedback. Idea seems very nice, but I'm not sure how that would look like..

Modules contain components, so to visualise it we'd need some kind of containers (modules) for nodes (components).

With current implementation (force graph), I don't see how that could possibly work

— Reply to this email directly or view it on GitHub <

https://github.com/filso/ng-dependency-graph/issues/9#issuecomment-168497075

.

— Reply to this email directly or view it on GitHub < https://github.com/filso/ng-dependency-graph/issues/9#issuecomment-168531104

.

— Reply to this email directly or view it on GitHub https://github.com/filso/ng-dependency-graph/issues/9#issuecomment-169288363 .

filso commented 8 years ago

That looks very cool! Well done finding it. I don't see any reasons why it wouldn't work well. We'd probably have to sacrifice unsticking

Give it a go if you'd like, otherwise I'll take a look and implement it. Let me know if you need any help. I think it should be applied to "Modules" view

Thanks a lot for feedback and help!

chiptus commented 8 years ago

Ok, I finally have some time for this. I'm not sure where to start. we have both double click and click events used. maybe right click and choose show components?

and what is the procedure for testing on chrome? gulp build? or should it be ready when loading unpack?

ramunsk commented 8 years ago

+1 for a feature This would be a huge helper in big angular projects

filso commented 8 years ago

hi @chiptus sorry I was on holiday in China and just read this. Have you done any work on this? Otherwise, I'll implement this soon - thanks a lot for idea and links to implementation!

As for your question - you can just run gulp to run all JS / CSS helpers with development server. It will start BrowserSync server on localhost:3000 which looks like page project: http://angularjs-graph.org/

chiptus commented 8 years ago

Hope you had fun :)

I didn't get to implement this. just cloned the repo and got back to work. sorry.

On Sun, Mar 6, 2016 at 8:18 PM Filip Sobczak notifications@github.com wrote:

hi @chiptus https://github.com/chiptus sorry I was on holiday in China and just read this. Have you done any work on this? Otherwise, I'll implement this soon - thanks a lot for idea and links to implementation!

As for your question - you can just run gulp to run helpers with development server

— Reply to this email directly or view it on GitHub https://github.com/filso/ng-dependency-graph/issues/9#issuecomment-192954159 .