filtron / MarkovKernels.jl

Marginal distributions and Markov kernels that play nice with each other for the purpose of Bayesian state estimation.
MIT License
17 stars 2 forks source link

Univariate Normals #103

Closed filtron closed 3 months ago

filtron commented 3 months ago

Fixes #101 and #102

What has been done:

Some things to consider:

Future work:

codecov[bot] commented 3 months ago

Codecov Report

Attention: Patch coverage is 20.00000% with 8 lines in your changes missing coverage. Please review.

Project coverage is 91.93%. Comparing base (44e6544) to head (7bf0ecd). Report is 7 commits behind head on main.

Files Patch % Lines
src/distributions/uvnormal.jl 0.00% 7 Missing :warning:
src/covariance_parameter.jl 0.00% 1 Missing :warning:
Additional details and impacted files ```diff @@ Coverage Diff @@ ## main #103 +/- ## ========================================== - Coverage 95.41% 91.93% -3.49% ========================================== Files 16 19 +3 Lines 393 409 +16 ========================================== + Hits 375 376 +1 - Misses 18 33 +15 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

filtron commented 3 months ago

I had one new comment. In addition, as you say that this fixes #101, should we maybe add a test that ensures that this is acutally the case? Otherwise if you didn't check that this actually works now, I would suggest not closing #101 yet.

I added a test to make sure you can add constructor methods for normals with PSDmatrix now.