search

filyp / autocorrect

Spelling corrector in python
GNU Lesser General Public License v3.0
448 stars 79 forks source link

Drop support for Python2 #2

Closed ju-sh closed 4 years ago

ju-sh commented 4 years ago

Can we focus on Python3 and drop support for Python2 since it has reached end of life?

It would allow the project to use the newer features.

And maybe we should also choose which Python3 version we support? How about >=3.6?

May this fork rejuvante the package. :-)

Edit: I noticed the typo in the last line afterwards. I will leave it there. :D

filyp commented 4 years ago

Hm, I was thinking about that. So far, keeping python2 compatibility was rather easy, so I kept it, in case some people are stuck with the old version for whatever reason. (Although I miss f-strings :/)

If some future improvement turns out to be incompatible with python2 I'm ready to drop that support. Do you have some particular python3 features you'd like to use?

Edit: On second thought, those unfortunate python2 prisoners can still use previous versions of the package. And it's true that supporting them drags the package down. I think I'll drop that support in some newer release. I'm looking forward to this rejuvante :>

Edit: And yeah, 3.6 seems reasonable.

ju-sh commented 4 years ago

Yeah, projects still stuck with Python2 can probably manage with the old version anyway.

And yes, who doesn't like fstrings :-D

The code base is tiny and the needed modification should be easy. Do you mind if I do it?

filyp commented 4 years ago

Sure, go ahead :)

ju-sh commented 4 years ago

I made some change at https://github.com/fsondej/autocorrect/pull/4

filyp commented 4 years ago

Awesome, I merged it.