search

fimad / prometheus-haskell

Haskell client library for exposing prometheus.io metrics.
84 stars 48 forks source link

Expose Bucket type synonym #58

Closed MaxGabriel closed 4 years ago

MaxGabriel commented 4 years ago

Currently Bucket is referenced in type signatures in Prometheus, but it's not exported. I think this was probably just an oversight.

I tested this by running stack haddock and verifying Bucket shows up, and is linked to correctly.

I searched Stackage and other uses of the word "Bucket" aren't in Base or anything, so it's unlikely that exporting this will cause naming collisions https://www.stackage.org/lts-16.1/hoogle?q=Bucket

I'm not sure what your release policy is. I just added my change to the unreleased section of the changelog for now, but I'm happy to bump the version in the cabal file if you'd like

MaxGabriel commented 4 years ago

Old:

image

New:

image

MaxGabriel commented 4 years ago

The tests are failing on 7.8, but it seems unrelated to my PR:

<command line>: cannot satisfy -package-id wai-3.2.1.1-a653e76b60602d54a54fcbe4e07de7e1
    (use -v for more information)
The command "cd ../wai-middleware-prometheus && cabal build && cabal test" exited with 1.
fimad commented 4 years ago

Yep, I think this was just an oversight. Thanks for scouting around for name collisions and adding an entry to the changelist! I'll update the section header when I go through and bump version numbers.

I agree, it looks like there is something wrong generally with the 7.8 build and the failure is not related to this change.

MaxGabriel commented 4 years ago

Awesome, thanks!

fimad commented 4 years ago

Just pushed this in version 1.0.1.