search

fin-hypergrid / core

A canvas-based super high performant grid renderer API
MIT License
897 stars 144 forks source link

Behavior Change in Chrome 5X (Don't know exactly which version) breaks dragging protection #492

Open osbert-messerfs opened 7 years ago

osbert-messerfs commented 7 years ago

The following won't work in Chrome latest stable build https://github.com/openfin/fincanvas/blob/db990dae9b1ca5c34313b2f6311651a16677eb45/src/index.js#L610

Consider the following statement is true in latest Chrome:

document.body.style.cssText = '-webkit-user-select: none'; document.body.style.cssText === 'user-select: none;'

This result in once a drag action is detected in fincanvas in hypergrid, users will no longer be able to select any text even after the dragging ended.

Ref: https://github.com/openfin/fincanvas/issues/9

Dwaynekj commented 7 years ago

@osbert-messerfs Thanks for moving the conversation here. I'll follow up with you this week

osbert-messerfs commented 7 years ago

P.S. I think probably replace -webkit-user-select with user-select should get it working, or doing it in a more non-hacking way such as document.body.style.userSelect = 'none', but better leave with you guys to decide, as there might be browser compatibility considerations that I might haven't thought about.