Closed crispywalrus closed 6 years ago
Merging #59 into master will decrease coverage by
0.6%
. The diff coverage isn/a
.
@@ Coverage Diff @@
## master #59 +/- ##
==========================================
- Coverage 68.32% 67.71% -0.61%
==========================================
Files 9 8 -1
Lines 262 254 -8
Branches 3 3
==========================================
- Hits 179 172 -7
+ Misses 83 82 -1
Impacted Files | Coverage Δ | |
---|---|---|
...cala/featherbed/littlemacros/CoproductMacros.scala |
Continue to review full report at Codecov.
Legend - Click here to learn more
Δ = absolute <relative> (impact)
,ø = not affected
,? = missing data
Powered by Codecov. Last update 125ac5e...4e6b1c3. Read the comment docs.
oh, I've already opened #58 with almost the same changes.. but still can't figure out why tut compilation hangs
I did see that but opening a PR means I can iterate against the travis-ci builds faster. Using this vs fixing your initial PR ... don't care either way.
based on my experience with finagle-postgres and travis I've jumped to 2.12.2 to avoid the "build works, travis hangs" issue. I've notably not upgraded the docs pugings (other than tut) due to the plugin to autoplugin work. those changes should come in a different PR.
I've also left finagle at 6.43.0 to match finch (and my infrastructure)