search

finagle / featherbed

Asynchronous Scala HTTP client using Finagle, Shapeless and Cats
Apache License 2.0
137 stars 25 forks source link

Updating the circe dependency to 0.9-M2 #74

Closed harrydevnull closed 6 years ago

harrydevnull commented 6 years ago

I have updated circe dependency to 0.9.0-M2. This is a breaking change and so I have updated the main version to 0.3.2-snapshot ? (I am not sure on how to go about semantic versioning) changes seems to be minor.

codecov-io commented 6 years ago

Codecov Report

Merging #74 into master will not change coverage. The diff coverage is 100%.

Impacted file tree graph

@@           Coverage Diff           @@
##           master      #74   +/-   ##
=======================================
  Coverage   67.71%   67.71%           
=======================================
  Files           8        8           
  Lines         254      254           
  Branches        3        3           
=======================================
  Hits          172      172           
  Misses         82       82
Impacted Files Coverage Δ
...irce/src/main/scala/featherbed/circe/package.scala 100% <100%> (ø) :arrow_up:

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update 1cd0911...c438995. Read the comment docs.

harrydevnull commented 6 years ago

done

jeremyrsmith commented 6 years ago

LGTM. Merging and will release shortly. Thanks!