search

finagle / finagle-postgres

PostgreSQL protocol support for Finagle
Apache License 2.0
81 stars 39 forks source link

Twitter's use of finagle-postgres #248

Open willnorris opened 3 years ago

willnorris commented 3 years ago

Twitter has relatively recently begun work on an internal project that will be using the PostgreSQL wire protocol, and are hoping to use finagle-postgres for that since it's a great project. Obviously, @vkostyukov (and more recently @steveniemitz and I suspect others) from Twitter have been contributing to the project, but we're interested in upping our involvement a bit.

The first question, mostly for @leonmaia but really any interested contributor or user of the project, is whether you're open to us stepping in to help with the maintenance of the project more. And then related to that, we wanted to propose the idea of promoting finagle-postgres to being a core part of the finagle project alongside finagle-mysql, finagle-redis, etc. That would allow the CSL team inside of Twitter to more easily maintain it with the rest of Finagle to keep it in sync with any changes, etc.

Anyway, we really like the project and are excited about using it, and would love to help however we can. 🎉

vkostyukov commented 3 years ago

@jeremyrsmith @leonmaia One extra thing we probably want to do before moving stuff around is to uncouple finagle-postgres-shapeless and move it under its own repo (within the Finagle Org as well). Since our goal is to move finagle-postgres under twitter/finagle, having a bonus shapeless dependency is probably something we'd like to avoid.

What are your thoughts on this?

jeremyrsmith commented 3 years ago

Hi @willnorris and @vkostyukov!

I can't speak for any other contributors, but in my current role I don't use either finagle nor postgres. And I've got my OSS-hands rather full (so to speak). But, I'm happy to answer any questions that I can (though it's been a while since I've done much of anything on this project).

@vkostyukov I don't see any problem with separating the repositories, assuming it wouldn't affect the artifact org/name.

vkostyukov commented 3 years ago

Thanks, @jeremyrsmith! Yea I think we should keep the artifacts publishing (and their location) unchanged. The finagle-postgres artifacts, however, would be published with the rest of Finagle projects so under com.twitter.finagle vs. io.twitter.finagle.

vkostyukov commented 3 years ago

Hey @leonmaia! We're going to start working on this pretty soon-ish. We'll start with splitting the shapeless bits out into their own repo.

Again, please let us know your thoughts and feelings on this!