Closed caniszczyk closed 10 years ago
@p-antoine since I've done this a million times, I added the basics here: https://github.com/finagle/finagle-zookeeper/commit/76c0c45024034a66b630faa88f66aa14645275f8
I'll leave it to you to make sure the tests pass :)
@p-antoine I took a stab at making sure ZK was installed and running in the latest PR but the build still has issues in finding ZK running (the tests at least from what I can see)
https://travis-ci.org/finagle/finagle-zookeeper/builds/30874662
WARNING: Authentication to server has failed.Connection closed by server. [info] ConnectionTest: [info] - Server is in rw mode * FAILED * [info] com.twitter.finagle.ChannelClosedException: ChannelException at remote address: /127.0.0.1:2181 [info] at com.twitter.finagle.NoStacktrace(Unknown Source) [info] ... [info] - Connection using BufClient [info] - Test with 2 servers unavailable * FAILED * [info] com.twitter.finagle.exp.zookeeper.NoServerFound: No server available for connection [info] at com.twitter.finagle.exp.zookeeper.connection.HostProvider$$anonfun$scanHostList$1.applyOrElse(HostProvider.scala:183) [info] at com.twitter.finagle.exp.zookeeper.connection.HostProvider$$anonfun$scanHostList$1.applyOrElse(HostProvider.scala:181) [info] at scala.runtime.AbstractPartialFunction.apply(AbstractPartialFunction.scala:33) [info] at com.twitter.util.Future$$anonfun$rescue$1.apply(Future.scala:802) [info] at com.twitter.util.Future$$anonfun$rescue$1.apply(Future.scala:801) [info] at com.twitter.util.Promise$Transformer.liftedTree1$1(Promise.scala:93) [info] at com.twitter.util.Promise$Transformer.k(Promise.scala:93) [info] at com.twitter.util.Promise$Transformer.apply(Promise.scala:102) [info] at com.twitter.util.Promise$Transformer.apply(Promise.scala:84) [info] at com.twitter.util.Promise$$anon$2.run(Promise.scala:333)
I'm out of time today so I'll leave it up to you to follow up
Awesome, WTH, I thought I did something similar :)
We should do one :)
Let me know if you need help.