finagle / finch

Scala combinator library for building Finagle HTTP services
https://finagle.github.io/finch
Apache License 2.0
1.6k stars 221 forks source link

Streaming with Monix's Observable #1078

Open vkostyukov opened 5 years ago

vkostyukov commented 5 years ago

Looks like we have all the pieces in place to make this happen.

alexeygorobets commented 5 years ago

hi! What's a preferred implementation to address the issue that a monix Observable has a kind F[_], but in Finch a stream needs to be S[_[_], _]? Some class ObservableWrapper[F[_]: Effect, A](val observable: Observable[A]) to mimic it?

vkostyukov commented 5 years ago

@alexeygorobets How does Iterant relate to Observable? It seems to be in proper kind.

alexeygorobets commented 5 years ago

Sorry, somehow missing that we need Iterant. Can you please explain then why this issue is called so?

vkostyukov commented 5 years ago

Oh the original plan I had in mind was to integrate with Observable, but, as you noted, it doesn't have the right kind. I was wondering if Iterant could serve as well as a replacement for Observable.

alexeygorobets commented 5 years ago

Thanks! I will take it then.