search

final-form / final-form-calculate

Decorator for calculating field values based on other field values in 🏁 Final Form
MIT License
113 stars 26 forks source link

Typescript typings missing from 1.2.0 on yarnpkg.com #19

Closed chrismay closed 6 years ago

chrismay commented 6 years ago

What is the current behavior?

the final-form-calculate v1.2.0 package, when installed via yarn or npm, does not include typescript typings.

What is the expected behavior?

Typings should be included in 1.2.0 as per PR #12

Other information


$ curl -s https://registry.yarnpkg.com/final-form-calculate/-/final-form-calculate-1.2.0.tgz  | tar ztv
-rw-r--r-- 0/0            2467 1985-10-26 09:15 package/package.json
-rw-r--r-- 0/0            1071 1985-10-26 09:15 package/LICENSE
-rw-r--r-- 0/0            4719 1985-10-26 09:15 package/README.md
-rw-r--r-- 0/0            3794 1985-10-26 09:15 package/dist/final-form-calculate.cjs.js
-rw-r--r-- 0/0             192 1985-10-26 09:15 package/dist/final-form-calculate.cjs.js.flow
-rw-r--r-- 0/0            3712 1985-10-26 09:15 package/dist/final-form-calculate.es.js
-rw-r--r-- 0/0             192 1985-10-26 09:15 package/dist/final-form-calculate.es.js.flow
-rw-r--r-- 0/0            4342 1985-10-26 09:15 package/dist/final-form-calculate.umd.js
-rw-r--r-- 0/0             242 1985-10-26 09:15 package/dist/final-form-calculate.umd.js.map
-rw-r--r-- 0/0            1728 1985-10-26 09:15 package/dist/final-form-calculate.umd.min.js
-rw-r--r-- 0/0             112 1985-10-26 09:15 package/dist/final-form-calculate.umd.min.js.map
-rw-r--r-- 0/0             192 1985-10-26 09:15 package/dist/index.js.flow
-rw-r--r-- 0/0             448 1985-10-26 09:15 package/dist/types.js.flow

Building locally seems to include the dist/index.d.ts file as expected.

The package.json file says that it is "version": "1.2.0", but other files (e.g. dist/final-form-calculate.umd.js seem different to what's in master at the moment - in fact they look very similar (identical?) to v1.1.0

erikras commented 6 years ago

That's pretty bizarre. The build script clearly copies it to the dist folder, and does so when I run it. npm weirdness, I guess...

erikras commented 6 years ago

Should be fixed in v1.2.1.

chrismay commented 6 years ago

Thanks for the swift fix - 1.2.1 looks fine :-)