search

final-form / final-form-focus

🏁 Final Form "decorator" that will attempt to apply focus to the first field with an error upon an attempted form submission
MIT License
83 stars 15 forks source link

Keep dependencies as dependencies in cjs & esm builds, do not bundle … #1

Closed Andarist closed 6 years ago

Andarist commented 6 years ago

before 867 bytes after 595 bytes πŸ’° πŸ˜‰

codecov[bot] commented 6 years ago

Codecov Report

Merging #1 into master will not change coverage. The diff coverage is n/a.

Impacted file tree graph

@@          Coverage Diff          @@
##           master     #1   +/-   ##
=====================================
  Coverage     100%   100%           
=====================================
  Files           4      4           
  Lines          39     39           
  Branches       10     10           
=====================================
  Hits           39     39

Continue to review full report at Codecov.

Legend - Click here to learn more Ξ” = absolute <relative> (impact), ΓΈ = not affected, ? = missing data Powered by Codecov. Last update b906b01...26f4ad6. Read the comment docs.

erikras commented 6 years ago

🀯 I wonder if that would help any other of my libs?

Andarist commented 6 years ago

I've inspected react-final-form, final-form & final-form-focus and they have OK setup (at least for now, if you gonna add some dep anywhere, u might forget to update external). I might inspect more later and send appropriate PRs.