search

final-form / final-form-focus

🏁 Final Form "decorator" that will attempt to apply focus to the first field with an error upon an attempted form submission
MIT License
83 stars 15 forks source link

Add option for own findInput method #3

Closed nik-lampe closed 6 years ago

nik-lampe commented 6 years ago

PR for providing a custom findInput Method. See Issue https://github.com/final-form/final-form-focus/issues/2

codecov[bot] commented 6 years ago

Codecov Report

Merging #3 into master will not change coverage. The diff coverage is 100%.

Impacted file tree graph

@@          Coverage Diff          @@
##           master     #3   +/-   ##
=====================================
  Coverage     100%   100%           
=====================================
  Files           4      5    +1     
  Lines          39     43    +4     
  Branches       10     11    +1     
=====================================
+ Hits           39     43    +4
Impacted Files Coverage Δ
src/decorator.js 100% <100%> (ø) :arrow_up:
src/findInput.js 100% <100%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update b8b774d...4edc943. Read the comment docs.

erikras commented 6 years ago

Gorgeous work. Flawless! 👍

My only PR advice, since you specifically asked for it, is to use the special phrase "Fixes #2" or "Closes #2" (rather than "See issue #2"), which will cause Github to automatically close that issue when I click the magical "Merge" button.

erikras commented 6 years ago

Published in v1.1.0.