Closed BowlingX closed 5 years ago
Merging #12 into master will not change coverage. The diff coverage is
100%
.
@@ Coverage Diff @@
## master #12 +/- ##
=====================================
Coverage 100% 100%
=====================================
Files 2 2
Lines 36 38 +2
Branches 16 17 +1
=====================================
+ Hits 36 38 +2
Impacted Files | Coverage Δ | |
---|---|---|
src/Html5ValidationField.js | 100% <100%> (ø) |
:arrow_up: |
Continue to review full report at Codecov.
Legend - Click here to learn more
Δ = absolute <relative> (impact)
,ø = not affected
,? = missing data
Powered by Codecov. Last update 090a232...dab9c8a. Read the comment docs.
Anything else you require for merging / checking this PR?
@erikras This pull request is already quite long in the pipeline, do you request any more comment / feedback, tests etc.?
Thank you so much for this library. This pull request will add the ability to specify functions as message props:
Example
This is especially usefull when defining default translation messages for all fields (here with
react-intl
):Currently this requires to create an object on each render with default messages based on the Field's props. I think this would provide a more elegant and performant way.