final-form / react-final-form-html5-validation

A swap-in replacement for 🏁 React Final Form's <Field> component to provide HTML5 Validation
MIT License
57 stars 8 forks source link

Upgrade react-final-form dev dependency to 6.3.0 #17

Closed TylerRick closed 4 years ago

TylerRick commented 5 years ago

Tests appear to be broken when testing against react-final-form 6.3.0. Would someone please help fix them?

TylerRick commented 5 years ago

It has all kinds of test failures, but all I did was update the react-final-form dependency to 6.3.0. Help?

[test]   ● Html5ValidationField › Html5ValidationField.rules › should pass "required" through to input
333[test] 
334[test]     Did not find exactly one match (found: 0) for tag:input
335[test] 
336[test]       29 |         </Form>
337[test]       30 |       )
338[test]     > 31 |       const input = TestUtils.findRenderedDOMComponentWithTag(dom, 'input')
339[test]          |                               ^
340[test]       32 |       expect(input).toBeDefined()
341[test]       33 |       const attributes = getAttributes(input)
342[test]       34 |       Object.keys(rule).forEach(key => expect(attributes[key]).toBe(rule[key]))
343[test] 
344[test]       at Object.findRenderedDOMComponentWithTag (node_modules/react-dom/cjs/react-dom-test-utils.development.js:1083:13)
345[test]       at findRenderedDOMComponentWithTag (src/Html5ValidationField.test.js:31:31)
346[test]       at Object.testPassThrough (src/Html5ValidationField.test.js:39:7)
347[test] 
348[test]   ● Html5ValidationField › Html5ValidationField.rules › should pass "pattern" through to input
349[test] 
350[test]     Did not find exactly one match (found: 0) for tag:input
351[test] 
352[test]       29 |         </Form>
353[test]       30 |       )
354[test]     > 31 |       const input = TestUtils.findRenderedDOMComponentWithTag(dom, 'input')
355[test]          |                               ^
356[test]       32 |       expect(input).toBeDefined()
357[test]       33 |       const attributes = getAttributes(input)
358[test]       34 |       Object.keys(rule).forEach(key => expect(attributes[key]).toBe(rule[key]))
359[test] 
360[test]       at Object.findRenderedDOMComponentWithTag (node_modules/react-dom/cjs/react-dom-test-utils.development.js:1083:13)
361[test]       at findRenderedDOMComponentWithTag (src/Html5ValidationField.test.js:31:31)
362[test]       at Object.testPassThrough (src/Html5ValidationField.test.js:43:7)
erikras commented 4 years ago

Gonna do this manually on next release. Thanks for all the love!