search

final-form / react-final-form-html5-validation

A swap-in replacement for 🏁 React Final Form's <Field> component to provide HTML5 Validation
MIT License
57 stars 8 forks source link

Use babel loose mode #3

Closed Andarist closed 6 years ago

Andarist commented 6 years ago

This reduces bundle size a little bit (thanks to loose mode) and keeps babel configs in sync between babelrc and rollup.config.js

es bundle size went down from 2097 to 1903 (gzipped, not minified) umd.min bundle size went down from 1525 to 1405 (gzipped, minified)

Those numbers assumes ofc that #2 is merged in.

codecov[bot] commented 6 years ago

Codecov Report

Merging #3 into master will not change coverage. The diff coverage is n/a.

Impacted file tree graph

@@          Coverage Diff          @@
##           master     #3   +/-   ##
=====================================
  Coverage     100%   100%           
=====================================
  Files           2      2           
  Lines          37     37           
  Branches       16     16           
=====================================
  Hits           37     37

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update 3f21321...4eadb3c. Read the comment docs.

erikras commented 6 years ago

Published in v1.0.1.

dist/react-final-form-html5-validation.es.js went from 730K to 5.4K. 😱