final-form / react-final-form-listeners

A collection of components to listen to 🏁 React Final Form fields

MIT License

93 stars 20 forks source link

TypeScript definitions #13

Closed yurist38 closed 4 years ago

yurist38 commented 5 years ago

Hello. I've added TypeScript definitions, partially tested on my project.

What was done:

Added a file with TypeScript definitions
Updated the build script to include this file into a build
Added types path into the package.json file

Thanks!

codecov[bot] commented 5 years ago

Codecov Report

Merging #13 into master will not change coverage. The diff coverage is n/a.

@@          Coverage Diff          @@
##           master    #13   +/-   ##
=====================================
  Coverage     100%   100%           
=====================================
  Files           4      4           
  Lines          46     46           
  Branches        6      6           
=====================================
  Hits           46     46

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update d76a99d...43af79b. Read the comment docs.

OlehDutchenko commented 4 years ago

most wanted! merge it))

sorokin-evgeni commented 4 years ago

Yes, merge it please. We need it!

LavaToaster commented 4 years ago

@erikras 👋 Have you had a chance to look at this? Or do you have better way of achieving what this library does?

LavaToaster commented 4 years ago

It may be worth contributing the types to DefinitelyTyped instead.

yurist38 commented 4 years ago

@Lavoaster yeah, I think we have no choice now. This PR is clearly ignored for a while already. If nobody from the team will review it in a week I think I'll find some time to open PR to DefinitelyTyped instead.

talyh commented 4 years ago

@yurist38 - thanks for the work!! Did you end up adding this do DefinitelyTyped instead? I couldn't find it there, so I'm guessing no, but thought I'd double check.

(Additionally, bump to @erikras - maybe timing is better now for reviewing this)

yurist38 commented 4 years ago

@talyh Yes, you right, I didn't add it to DefinitelyTyped indeed... Thank you for the reminder! Let's see, if this PR is not moving forward I'll try to find some time and publish it to DT repo...

yurist38 commented 4 years ago

@talyh @sorokin-evgeni @dutchenkoOleg @Lavoaster @erikras Since it's not going forward I have opened a PR to the DefinitelyTyped repo: https://github.com/DefinitelyTyped/DefinitelyTyped/pull/42577

talyh commented 4 years ago

Thank you @yurist38 !!

yurist38 commented 4 years ago

The PR to DefinitelyTypes is merged, so I'm closing this one because it doesn't go forward.