search

final-form / react-final-form-listeners

A collection of components to listen to 🏁 React Final Form fields
MIT License
93 stars 20 forks source link

Bump peerDependency react to include 18.0.0 #45

Open simian-loco opened 1 year ago

simian-loco commented 1 year ago

Resolves issue #41

mikaelengstrom commented 1 year ago

@erikras - Could you review and merge this? Would appreciate it very much :)

simian-loco commented 1 year ago

@mikaelengstrom @erikras -- This change eventually broke for me. It fixed my build and I only had a couple of implementations so I opened this merge up; but I did find that it eventually broke. I can't exactly remember what it was that broke; but I think it was a react API call somewhere which was incompatible with React 18. I ended up just refactoring out the two listener implementations I was using and removed this package from my dependencies.

I would close this merge as breaking; but perhaps this might be a good place for related discussion? @mikaelengstrom could you bump locally in your node_modules/react-final-form-listeners/package.json and see which react API call this breaks on? I think I was using onChange.

Edit: added some details

05/05/23 Update - I'll defer to others here regarding everything working as expected as I cannot reproduce the issue I mentioned above at this time and it was a pretty convoluted abstraction in the first place where the error was occurring.

mikaelengstrom commented 1 year ago

@simian-loco seems to work just fine in our app

SwinX commented 1 year ago

@erikras may you please consider merging this? We're maintaining pretty large project on React@18 with 50+ usages of library in huge forms. And still everything works as expected.

peiofour commented 9 months ago

Hello, it is possible to merge this please?

andremacnamara commented 8 months ago

@erikras Is this good to merge in?

comet-code-andrew commented 8 months ago

Is this going to be merge?

gordonk commented 7 months ago

I too would love to see this merged